[PATCH] D48530: [DAGCombiner] In foldSelectOfConstants, use 'sub C1+1, (zext Cond)' instead of 'add (sext Cond), C1+1'

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 12:44:34 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D48530#1147067, @craig.topper wrote:

> @spatel, what are you thoughts on this?


Did we get the motivating cases with our other select patches? If not, can you post those? As-is, I don't see why we'd change this from these test diffs.


Repository:
  rL LLVM

https://reviews.llvm.org/D48530





More information about the llvm-commits mailing list