[PATCH] D48584: [InstCombine] Delay foldICmpUsingKnownBits until simple transforms are done

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 08:45:10 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D48584#1144405, @mkazantsev wrote:

> I think that these changes are practically either unimportant or positive. SCEV has reasons to prefer `lt/gt` comparisons over `ne/eq` because in certain cases it can derive more facts from it, however I'm not sure whether it has real profit anywhere or not. I can test it on our Java benchmarks, but don't have environment to run C++ clang tests properly, so I'd appreciate if you could help with it.


Ok - I need to get a test-suite machine set up again. I'll try to have some data by tomorrow.


https://reviews.llvm.org/D48584





More information about the llvm-commits mailing list