[PATCH] D48625: [ARM][AArch64] Armv8.4-A enablement

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 07:31:54 PDT 2018


SjoerdMeijer added inline comments.


================
Comment at: include/llvm/Support/ARMTargetParser.def:137
 ARM_ARCH_EXT_NAME("crypto",   ARM::AEK_CRYPTO,   "+crypto","-crypto")
+ARM_ARCH_EXT_NAME("sm4",      ARM::AEK_SM4,      "+sm4",   "-sm4")
+ARM_ARCH_EXT_NAME("sha3",     ARM::AEK_SHA3,     "+sha3",  "-sha3")
----------------
olista01 wrote:
> Why are these needed, if the sha3 and sm4 instructions are AArch64-only?
Think I just initially added these here, incorrectly, but then just forgot to remove them. Thanks, fixing this now!


https://reviews.llvm.org/D48625





More information about the llvm-commits mailing list