[PATCH] D48413: [llvm-objcopy] Add initial support for static libraries

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/Object.cpp:39
+  handleAllErrors(BufferOrErr.takeError(), [this](const ErrorInfoBase &) {
+    error("failed to open " + getName());
+  });
----------------
jhenderson wrote:
> This should use the error info's message. Otherwise, the user won't be able to know what is wrong. I think this is probably also one that is easy to test, by specifying a location in a non-existent directory?
the thing is that I moved this from the previous version (before my patch) without any of may changes, but okay, I'll fix it


Repository:
  rL LLVM

https://reviews.llvm.org/D48413