[PATCH] D48413: [llvm-objcopy] Add initial support for static libraries

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: test/tools/llvm-objcopy/basic-archive-copy.test:30
+
+# RUN: not llvm-objcopy %t.broken.a %t2.broken.a 2>&1 | FileCheck %s --check-prefix=BAD-FORMAT
+
----------------
jhenderson wrote:
> Does gnu objcopy produce an error in this case? If not, what does it do?
> 
> We should also check the case that if llvm-objcopy reports an error, what is the state of the archive? I'd expect it to be unchanged, even if the final member is the one with the error, but I'm open to other behaviours.
yes, it produces an error (i've double checked)


https://reviews.llvm.org/D48413