[PATCH] D48703: Add natvis files directly to the PDB instead of to the VS solution

[Zachary Turner via Phabricator via llvm-commits]

zturner created this revision.
zturner added reviewers: probinson, hans, smeenai, Bigcheese, aaron.ballman.
Herald added a subscriber: mgorny.

Adding natvis files to the VS solution means that if you use CMake to generate a VS solution, natvis will just work.  However, this is strictly inferior to putting the natvis files directly in the PDB.  For starters, it only works if you generate a VS project, which not everyone does, but even then it's link.exe specific.  PDB files support embedding natvis files, and this way it works everywhere.

I originally found out about this because I thought my natvis files weren't getting loaded because I wasn't getting visualization of `Optional<T>`.  Turns out that visualizer was just broken, so I went ahead and fixed it, and also added a visualizer for `Expected<T>` at the same time.

Not really sure who to add for a review here, so + a couple of random people


https://reviews.llvm.org/D48703

Files:
  clang/CMakeLists.txt
  llvm/CMakeLists.txt
  llvm/cmake/modules/HandleLLVMOptions.cmake
  llvm/utils/LLVMVisualizers/llvm.natvis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48703.153255.patch
Type: text/x-patch
Size: 4525 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180628/bab493e8/attachment.bin>