[PATCH] D46365: AMDGPU: Separate R600 and GCN TableGen files

[Jan Vesely via Phabricator via llvm-commits]

jvesely added a comment.

In https://reviews.llvm.org/D46365#1146098, @jvesely wrote:

> In https://reviews.llvm.org/D46365#1141392, @tstellar wrote:
>
> > In https://reviews.llvm.org/D46365#1140194, @jvesely wrote:
> >
> > > running llc through valgrind produced flood of 'Conditional jump or move depends on uninitialised value(s)'
> > >  269 errors from 24 contexts. Initialzieng just CaymanISA in R600SUbtarget gets rid of most of them.
> >
> >
> > These should be fixed now, can you re-test?
>
>
> Fails to build:
>  llvm-tblgen: Unknown command line argument '-gen-tgt-intrinsic'.  Try: '../../../bin/llvm-tblgen -help'
>  llvm-tblgen: Did you mean '-gen-tgt-intrinsic-impl'?
>  make[2]: *** [lib/Target/AMDGPU/CMakeFiles/AMDGPUCommonTableGen.dir/build.make:1730: lib/Target/AMDGPU/R600GenIntrinsics.inc.tmp] Error 1


After fixing the build file as tblgen suggested (and few local fixes in my own patches) it builds OK and there are no piglit regressions on my turks.
I think this should land rather soon, with a bunch of cleanup follow ups. Having things (files, classes) that are prefixed R600, AMDGPU, AMDGPUCommon, GCN, AMDGCN, and SI is rather confusing.


Repository:
  rL LLVM

https://reviews.llvm.org/D46365