[PATCH] D48672: [llvm-mca] Simplify eventing by adding an onEvent templated method.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 27 14:17:16 PDT 2018


mattd created this revision.
mattd added reviewers: andreadb, courbet, RKSimon.
Herald added subscribers: gbedwell, tschuett, javed.absar.

This patch eliminates some redundancy in iterating across Listeners for the
Instruction and Stall HWEvents, by introducing a template onEvent routine.
This change was suggested by @courbet in https://reviews.llvm.org/D48576.  I
 hope that this patch addresses that suggestion appropriately.  I do like this
change better than what we had previously.


https://reviews.llvm.org/D48672

Files:
  tools/llvm-mca/DispatchStage.cpp
  tools/llvm-mca/DispatchStage.h
  tools/llvm-mca/DispatchStatistics.cpp
  tools/llvm-mca/DispatchStatistics.h
  tools/llvm-mca/ExecuteStage.cpp
  tools/llvm-mca/HWEventListener.h
  tools/llvm-mca/InstructionTables.cpp
  tools/llvm-mca/RegisterFileStatistics.cpp
  tools/llvm-mca/RegisterFileStatistics.h
  tools/llvm-mca/ResourcePressureView.cpp
  tools/llvm-mca/ResourcePressureView.h
  tools/llvm-mca/RetireControlUnitStatistics.cpp
  tools/llvm-mca/RetireControlUnitStatistics.h
  tools/llvm-mca/RetireStage.cpp
  tools/llvm-mca/SchedulerStatistics.cpp
  tools/llvm-mca/SchedulerStatistics.h
  tools/llvm-mca/Stage.cpp
  tools/llvm-mca/Stage.h
  tools/llvm-mca/SummaryView.cpp
  tools/llvm-mca/SummaryView.h
  tools/llvm-mca/TimelineView.cpp
  tools/llvm-mca/TimelineView.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48672.153174.patch
Type: text/x-patch
Size: 14369 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180627/49e51195/attachment.bin>


More information about the llvm-commits mailing list