[PATCH] D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling()

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 27 11:06:32 PDT 2018


stefanp created this revision.
stefanp added reviewers: kbarton, nemanjai, sfertile, lei, syzaara, hfinkel, echristo.
Herald added a subscriber: qcolombet.

As we already return true from needsAggressiveScheduling() for the most recent hardware it would be cleaner to just return true for all PowerPC hardware.

Three tests were deleted because they were looking for correct spill behavior however with the use of the machine scheduler the spill is not longer required and therefore cannot be checked for correctness

  2011-12-05-NoSpillDupCR.ll
  save-cr-ppc32svr4.ll
  save-crbp-ppc32svr4.ll

Also, the following test `ppc64-gep-opt.ll` was cut down significantly because the removal of  `needsAggressiveScheduling()` also means that `PPCSubtarget::useAA()` always returns true. That test checked with and without AA. I have removed the without AA portion of the test.


https://reviews.llvm.org/D48663

Files:
  lib/Target/PowerPC/PPCSubtarget.cpp
  test/CodeGen/PowerPC/2008-10-28-f128-i32.ll
  test/CodeGen/PowerPC/2011-12-05-NoSpillDupCR.ll
  test/CodeGen/PowerPC/coalesce-ext.ll
  test/CodeGen/PowerPC/fp128-bitcast-after-operation.ll
  test/CodeGen/PowerPC/i1-to-double.ll
  test/CodeGen/PowerPC/lsa.ll
  test/CodeGen/PowerPC/ppc32-vacopy.ll
  test/CodeGen/PowerPC/ppc64-gep-opt.ll
  test/CodeGen/PowerPC/save-cr-ppc32svr4.ll
  test/CodeGen/PowerPC/save-crbp-ppc32svr4.ll
  test/CodeGen/PowerPC/tls.ll
  test/CodeGen/PowerPC/unal-altivec.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48663.153128.patch
Type: text/x-patch
Size: 46184 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180627/93b6b251/attachment-0001.bin>


More information about the llvm-commits mailing list