[PATCH] D48654: [lldbsuite] Fix TestBreakpointHitCount on Windows

Stella Stamenova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 27 09:16:07 PDT 2018


stella.stamenova created this revision.
stella.stamenova added reviewers: zturner, asmith.
Herald added a subscriber: llvm-commits.

On Windows, the newer DIA SDKs end up producing function names that contain the return type as well. This means that the function name returned in the test will contain the return type (int) in addition to the name of the function and the type of the input (a(int)). To account for the possibility of both, the test should pass if the function name matches either pattern.


Repository:
  rL LLVM

https://reviews.llvm.org/D48654

Files:
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py


Index: packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py
===================================================================
--- packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py
+++ packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py
@@ -42,7 +42,7 @@
             "There should be a thread stopped due to breakpoint")
 
         frame0 = thread.GetFrameAtIndex(0)
-        self.assertEqual(frame0.GetFunctionName(), "a(int)");
+        self.assertTrue(frame0.GetFunctionName() == "a(int)" or frame0.GetFunctionName() == "int a(int)");
 
         process.Continue()
         self.assertEqual(process.GetState(), lldb.eStateExited)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48654.153104.patch
Type: text/x-patch
Size: 795 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180627/c978b3f3/attachment.bin>


More information about the llvm-commits mailing list