[PATCH] D48592: [llvm-exegesis] Add partial X87 support.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/BenchmarkRunner.cpp:201
+    const Instruction &Instr) const {
+  const AliasingConfigurations SelfAliasing(Instr, Instr);
+  SnippetPrototype Prototype;
----------------
Move just above the if (where it's used)


================
Comment at: tools/llvm-exegesis/lib/BenchmarkRunner.cpp:203
+  SnippetPrototype Prototype;
+  InstructionInstance II(Instr);
+  if (SelfAliasing.empty()) {
----------------
Move below `if (SelfAliasing.empty())` block.


================
Comment at: tools/llvm-exegesis/lib/Latency.cpp:92
   }
+  llvm::consumeError(SelfAliasingPrototype.takeError());
+  // No self aliasing, trying to create a dependency through another opcode.
----------------
this is not needed it you use the llvm idiom
```
if(auto SelfAliasingPrototype = generateSelfAliasingPrototype(Instr)) {
   return SelfAliasingPrototype;
}
```


Repository:
  rL LLVM

https://reviews.llvm.org/D48592