[PATCH] D48331: [WIP][DebugInfo][InstCombine] Preserve DI after merging zext instructions

Anastasis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 27 04:11:21 PDT 2018


gramanas updated this revision to Diff 153040.
gramanas added a comment.

- Update the scalar case according to the comments
- Postpone vector case for a later patch


Repository:
  rL LLVM

https://reviews.llvm.org/D48331

Files:
  lib/Transforms/InstCombine/InstCombineCasts.cpp
  test/Transforms/InstCombine/debuginfo-trunc-and-zext.ll


Index: test/Transforms/InstCombine/debuginfo-trunc-and-zext.ll
===================================================================
--- /dev/null
+++ test/Transforms/InstCombine/debuginfo-trunc-and-zext.ll
@@ -0,0 +1,21 @@
+; RUN: opt -debugify -instcombine -S < %s | FileCheck %s
+
+target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32"
+
+; Test that when zext is evaluated in different type
+; we preserve the debug information in the resulting
+; instruction.
+
+define i32 @test-scalar(i32 %x, i32 %y) {
+  %A = trunc i32 %x to i8
+  %B = trunc i32 %y to i8
+  %C = mul i8 %A, %B
+  %D = zext i8 %C to i32
+  ret i32 %D
+}
+
+; CHECK: define i32 @test-scalar
+; CHECK: {{.*}} = mul i32 {{.*}}
+; CHECK-NEXT: call void @llvm.dbg.value{{.*}}
+; CHECK: {{.*}} = and i32 {{.*}}
+; CHECK-NEXT: call void @llvm.dbg.value{{.*}}
Index: lib/Transforms/InstCombine/InstCombineCasts.cpp
===================================================================
--- lib/Transforms/InstCombine/InstCombineCasts.cpp
+++ lib/Transforms/InstCombine/InstCombineCasts.cpp
@@ -1079,6 +1079,17 @@
     Value *Res = EvaluateInDifferentType(Src, DestTy, false);
     assert(Res->getType() == DestTy);
 
+    // When DestTy is integer, try to preserve any debug values
+    // referring to the zext being replaced.
+    // TODO: this should work for vectors as well, possibly
+    // via the use of dwarf fragments
+    if (DestTy->isIntegerTy()) {
+      insertReplacementDbgValues(
+          *Src, *Res, CI, [](DbgInfoIntrinsic &OldDII) -> DIExpression * {
+            return OldDII.getExpression();
+          });
+    }
+
     uint32_t SrcBitsKept = SrcTy->getScalarSizeInBits()-BitsToClear;
     uint32_t DestBitSize = DestTy->getScalarSizeInBits();
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48331.153040.patch
Type: text/x-patch
Size: 1840 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180627/1e69f09d/attachment.bin>


More information about the llvm-commits mailing list