[PATCH] D48594: [AArch64] Remove Duplicate FP16 Patterns with same encoding, match on existing patterns.

[Luke Geeson via Phabricator via llvm-commits]

LukeGeeson marked 2 inline comments as done.
LukeGeeson added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.td:4944
 // Having the same base pattern for fp <--> int totally freaks it out.
+// Split these patterns into a separate pattern
+
----------------
SjoerdMeijer wrote:
> I see what you've done here, but I am not sure this comment on itself will be very clear. I think just omitting it is clearer.
Removed.


================
Comment at: lib/Target/AArch64/AArch64RegisterInfo.cpp:78
+                                       unsigned Idx) const {
+  // The sub_8bit sub-register index is more constrained in 32-bit mode.
+  // It behaves just like the sub_8bit_hi index.
----------------
SjoerdMeijer wrote:
> What is this comment about?
A side effect, renamed/removed. 


https://reviews.llvm.org/D48594