[PATCH] D48621: Report an error for an unknown -z option.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 27 00:57:05 PDT 2018


grimar added a comment.

In https://reviews.llvm.org/D48621#1144498, @ruiu wrote:

> The problem of doing an error check this way is, when it is easy to make the list inconsistent you remove an -z option support. However, that's not a real concern because we can't remove any -z option once it is implemented and released. So this simple way should suffice.


Yeah, speaking honestly my approach felt a bit tricky to me. But I was not sure that dumb way (which is first that comes to mind) is acceptable either. I think I am happy with it.


Repository:
  rL LLVM

https://reviews.llvm.org/D48621





More information about the llvm-commits mailing list