[PATCH] D48394: [WebAssembly] Error on mismatched function signature in final output

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I'm not sure if this is a good thing to do, because my understanding is that -gc-sections shouldn't generally change the linking semantics except it will produce a smaller binary. With this change, you are now easy to write code that links only when you pass -gc-sections. This is perhaps not problematic for wasm because -gc-section is on by default, but still, I feel like -gc-sections shouldn't do anything more than reducing the output size. What do you think?



================
Comment at: lld/trunk/wasm/SymbolTable.cpp:125
+
+    std::string msg = ("function signature mismatch: " + Existing->getName() +
+                       "\n>>> defined as " + toString(*OldSig) + " in " +
----------------
msg -> Msg


Repository:
  rL LLVM

https://reviews.llvm.org/D48394