[PATCH] D48111: [JumpThreading] Don't try to rewrite a use if it's already valid.

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 26 17:23:24 PDT 2018


brzycki added a comment.

In https://reviews.llvm.org/D48111#1144223, @mzolotukhin wrote:

> > do you happen to know why?
>
> The difference compared to the old `SSAUpdater` is in how we handled uses and defs located in the same block - it did not lead to a problem with the old `SSAUpdater`, but was unnecessary anyway, since such uses don't need to be rewritten (not in general, but in this particular case when the use is still dominated by its existing def).
>
> Michael


Thanks @mzolotukhin for the explanation. And for what it's worth, a delayed LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D48111





More information about the llvm-commits mailing list