[PATCH] D45454: Make __gcov_flush visible outside a shared library

[Marco Castelluccio via Phabricator via llvm-commits]

marco-c added a comment.

Yes, the behavior changed very recently, I would be surprised if
somebody came to depend on it. It's more likely that some clients are
depending on the old behavior.

- Marco.

Il 26/06/2018 22:43, Stephen Hines via Phabricator ha scritto:

> srhines added a comment.
> 
> In https://reviews.llvm.org/D45454#1144099, @davidxl wrote:
> 
>> GCC's behavior is not documented and it also has changed over the years.
>> 
>> Unless there is a bug, changing LLVM's gcov_flush visibility can potentially break clients that depend on this behavior.
> 
> I think that's the issue though. LLVM changed visibility of this function recently too. We had Android code depending on this function being visible, and that broke.
> 
> https://reviews.llvm.org/D45454


https://reviews.llvm.org/D45454