[PATCH] D48396: [MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an updater API to remove blocks.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

LGTM with one remaining nit. Thanks again!



================
Comment at: lib/Analysis/MemorySSA.cpp:1623
+
+  BlockNumberingValid.erase(BB);
 }
----------------
Nit: can we put this in the `if (Accesses->empty())` block?

I think the purpose is just to guard us from dangling pointers, and the only time we should (reasonably) carry a dangling pointer here is if we're removing the last access from this block.


Repository:
  rL LLVM

https://reviews.llvm.org/D48396