[PATCH] D48241: [DebugInfo] Emit ObjC methods as part of interface.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4239
+    // Add methods to interface.
+    for (auto p : ObjCMethodCache) {
+      if (p.second.empty())
----------------
aprantl wrote:
> JDevlieghere wrote:
> > dexonsmith wrote:
> > > Some comment for "p" here.
> > Fixed; I'll update the rest of the file in a follow-up to keep things consistent.
> Unfortunately CFE doesn't seem to consistently use the LLVM coding style: A lot of CFE developers seem to prefer lower-case variable names. I don't know if that is a historic artifact or a conscious decision.
Probably safe to assume it's historic - I don't think there's any intentional diversion from the LLVM style guide, maybe just lazy/accidental "being consistent" with the surrounding code & no one's bothered to do bigger cleanups.


https://reviews.llvm.org/D48241