[PATCH] D48504: [WIP] Add InsertionOrderSet, with constant-time insertion and removal.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 26 11:20:36 PDT 2018


efriedma added a comment.

> Imagine the case where we insert N elements and we erase M with M being almost the size of N

This is essentially the issue I noted with the comment: "It doesn't clean out dead entries in the vector when the set is rehashed".  I mean, I guess it's not exactly the same thing, but I think we end up rehashing in almost all the scenarios where this would matter, and we could add a shrink_to_fit method for other cases.


Repository:
  rL LLVM

https://reviews.llvm.org/D48504





More information about the llvm-commits mailing list