[PATCH] D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork()

[Alex Gaynor via Phabricator via llvm-commits]

alex marked an inline comment as done.
alex added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_posix_libcdep.cc:443
+// Android and we can drop that.
+#if !SANITIZER_ANDROID || __ANDROID_API__ >= 28
+pid_t StartSubprocess(const char *program, const char *const argv[],
----------------
eugenis wrote:
> This check can be done at runtime by using weak declarations.
> 
Hmm, it's kind of a pain because there's several functions involved, and also struct declarations. How important is it to do this at runtime?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48451