[PATCH] D48597: [LoopInstSimplify] Discard SCEV if simplification happened.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 26 10:33:00 PDT 2018


lebedev.ri abandoned this revision.
lebedev.ri added a comment.

In https://reviews.llvm.org/D48597#1143719, @sanjoy wrote:

> In https://reviews.llvm.org/D48597#1143657, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D48597#1143645, @sanjoy wrote:
> >
> > > IMO this doesn't seem like an invalidation bug -- SCEV Expander needs to be smarter about dealing with these kinds of simplifications.
> >
> >
> > Does this sound better?
>
>
> Yes -- that seems better to me.


Superseded by https://reviews.llvm.org/D48599
Although that is a less general fix, so there may be other problems.


Repository:
  rL LLVM

https://reviews.llvm.org/D48597





More information about the llvm-commits mailing list