[PATCH] D48085: [DAGCombiner] restrict (float)((int) f) --> ftrunc with no-signed-zeros

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 26 08:54:54 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D48085#1143602, @lebedev.ri wrote:

> I still think the docs need //some// adjustment.
>  And not for all arches the there are full set of tests (i.e. one with `"no-signed-zeros-fp-math"="true"`, one without).
>  But this is a regression, so i'd guess that can be iterated later on.
>
> It would be best if someone else could agree/disagree, but other than that, LG.


Thanks! I'm not opposed to rewording the docs, but I'm also not sure how to adjust them to make it better rather than worse.

If anyone would like to take a shot at that, I'm happy to review (and as I said, I think any text tweaking should be independent of this code change...though others may disagree with that assessment).


https://reviews.llvm.org/D48085





More information about the llvm-commits mailing list