[PATCH] D48591: [TargetLowering] isVectorClearMaskLegal - use ArrayRef<int> instead of const SmallVectorImpl<int>&

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

Not sure when the ArrayRef would be insufficient, but it can always be changed back if that is actually necessary.

LGTM.



================
Comment at: include/llvm/CodeGen/TargetLowering.h:751-753
   /// Similar to isShuffleMaskLegal. This is used by Targets can use this to
   /// indicate if there is a suitable VECTOR_SHUFFLE that can be used to replace
   /// a VAND with a constant pool entry.
----------------
Fix the comment typo since we're making a change - delete "This is used by".


================
Comment at: lib/Target/X86/X86ISelLowering.h:996-998
     /// Similar to isShuffleMaskLegal. This is used by Targets can use this to
     /// indicate if there is a suitable VECTOR_SHUFFLE that can be used to
     /// replace a VAND with a constant pool entry.
----------------
Shouldn't need to repeat the documentation comment from the base class?


Repository:
  rL LLVM

https://reviews.llvm.org/D48591