[PATCH] D48354: [LoopIdiomRecognize] Support for loops that use LSHR instruction added.

Olga Moldovanova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 22:25:47 PDT 2018


ovmold updated this revision to Diff 152836.
ovmold added a comment.

> Can you add
> 
>   else
>     llvm_unreachable("Unexpected opcode!);
> 
> 
> It should only be of the two shift opcodes and if for some reason that fails we should error. It also make the code behavior more obvious.

'llvm_unreachable("Unexpected opcode!")' added, code formatting done


Repository:
  rL LLVM

https://reviews.llvm.org/D48354

Files:
  lib/Transforms/Scalar/LoopIdiomRecognize.cpp
  test/Transforms/LoopIdiom/X86/ctlz.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48354.152836.patch
Type: text/x-patch
Size: 9009 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180626/863078f4/attachment.bin>


More information about the llvm-commits mailing list