[PATCH] D48583: CFI: Print DSO names for failed cross-DSO icalls

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 21:18:52 PDT 2018


pcc added inline comments.


================
Comment at: test/cfi/cross-dso-diagnostic.cpp:20
+  // CHECK: getpid defined here
+  // CHECK: check failed in {{.*}}, destination function located in {{.*}}
+  void (*fp)(int) =
----------------
Would it be possible to improve the diagnostic testing here? I'm thinking that you could have the test build a DSO named with a specific suffix, name the executable using a different suffix and test for both suffixes here (and below).


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48583





More information about the llvm-commits mailing list