[PATCH] D48509: Improve crash unwinding on Fuchsia

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: lib/fuzzer/FuzzerUtilFuchsia.cpp:162
+  for (;;) {
     exit(1);
   }
----------------
Do you care about `atexit` hooks being executed? I think this should probably use `_exit` instead.


================
Comment at: lib/fuzzer/FuzzerUtilFuchsia.cpp:183
+    "ud2\n"
+#else  // defined(__aarch64__)
+    ".cfi_return_column 33\n"
----------------
I'd use an explicit `#elif defined(__aarch64__)` and `#error` in the `#else` case. You never know when someone tries to compile this on some other architecture.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48509