[PATCH] D48576: [llvm-mca] Register listeners with stages; remove Pipeline dependency from Stage.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 16:47:25 PDT 2018


mattd created this revision.
mattd added reviewers: andreadb, courbet, RKSimon.
Herald added subscribers: gbedwell, tschuett.

This patch removes a few callbacks from Pipeline.  It comes at the cost of
registering Listeners with all Stages.  Not all stages need listeners or issue
callbacks, this registration is a bit redundant.  However, as we build-out the
API, this redundancy can disappear.

The main purpose here is to move callback code from the Pipeline and into the
stages that actually issue those callbacks. This removes the back-pointer to
the Pipeline that was put into a few Stage subclasses.


https://reviews.llvm.org/D48576

Files:
  tools/llvm-mca/DispatchStage.cpp
  tools/llvm-mca/DispatchStage.h
  tools/llvm-mca/ExecuteStage.cpp
  tools/llvm-mca/ExecuteStage.h
  tools/llvm-mca/Pipeline.cpp
  tools/llvm-mca/Pipeline.h
  tools/llvm-mca/RetireStage.cpp
  tools/llvm-mca/RetireStage.h
  tools/llvm-mca/Stage.cpp
  tools/llvm-mca/Stage.h
  tools/llvm-mca/llvm-mca.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48576.152804.patch
Type: text/x-patch
Size: 13636 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180625/400cf896/attachment.bin>


More information about the llvm-commits mailing list