[PATCH] D48567: [COFF] Fix constant sharing regression for MinGW

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: include/llvm/CodeGen/TargetLoweringObjectFileImpl.h:137
 
+  Triple TT;
+
----------------
rnk wrote:
> I'd prefer it if we didn't put this here, but instead put something in MCAsmInfo, like the existing `HasCOFFAssociativeComdats`.
Ok, what'd be a sensible name for it - `HasCOFFComdatConstantSections`?


================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1354-1356
+  if (!TT.isKnownWindowsMSVCEnvironment() &&
+      !TT.isWindowsItaniumEnvironment() &&
+      !TT.isWindowsCoreCLREnvironment())
----------------
rnk wrote:
> It'd be nicer to spell this as a positive check for a gnu or cygwin environment.
Yes, it probably would. I matched the condition used in the other function moved in the commit that introduced the issue, but I can change it.


Repository:
  rL LLVM

https://reviews.llvm.org/D48567