[PATCH] D48525: Handle NetBSD specific path in findDebugBinary()

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 11:48:47 PDT 2018


krytarowski added inline comments.


================
Comment at: lib/DebugInfo/Symbolize/Symbolize.cpp:195
   }
+#if defined(__NetBSD__)
+  // Try /usr/libdata/debug/path/to/original_binary/debuglink_name
----------------
vitalybuka wrote:
> krytarowski wrote:
> > vitalybuka wrote:
> > > Can we just try both paths and have the same behavior everywhere?
> > A similar ifdef is in LLDB.. but I will change the code to try out both paths.
> Thanks. I'd prefer version without ifdef.
> But if you get pushback from lldb, please just make it consistent.
I will go for ifdef, as [likely] /usr/libdata will be never valid for others and /usr/lib never valid for NetBSD.


Repository:
  rL LLVM

https://reviews.llvm.org/D48525





More information about the llvm-commits mailing list