[PATCH] D48422: [CMake] Add compiler-rt header files to the list of sources for targets when building with an IDE

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added a comment.

Besides the naming nit, this looks good to me, but I'm not a CMake expert. @george.karpenkov could you review this?



================
Comment at: cmake/Modules/AddCompilerRT.cmake:61
+  # Add headers to LIB_SOURCES for IDEs
+  crt_process_sources(LIB_SOURCES
+    ${LIB_SOURCES}
----------------
Please rename "crt" to "compiler_rt" (throughout the patch). I don't think we're using "crt" to mean "compiler-rt" anywhere in the codebase.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48422