[PATCH] D48331: [WIP][DebugInfo][InstCombine] Preserve DI after merging zext instructions

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCasts.cpp:1109
+    if (MaskedValueIsZero(
+            Res, APInt::getHighBitsSet(DestBitSize, DestBitSize - SrcBitsKept),
+            0, &CI))
----------------
vsk wrote:
> gramanas wrote:
> > This and the following were changed by clang-format, I hope there is no problem formating those, since my work is done nearby.
> This does pose a problem. Please avoid re-formatting code unrelated to your patch. This makes diffs harder to read, and makes attribution harder when looking at git history. If you'd like, you can use the clang-format-diff git hook to only reformat that changes you're making.
> 
> A simple way to remove these changes from your patch is to upstage your changes, then use `git add -p` to re-stage the chunks you want to keep.
If you are going to make a lot of changes to the same file, you can also do a separate commit that is just a clang-format of this file ahead of time.


Repository:
  rL LLVM

https://reviews.llvm.org/D48331