[PATCH] D48548: Add Triple::isMIPS()/isMIPS32()/isMIPS64(). NFC

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 07:17:52 PDT 2018


atanasyan added inline comments.


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp:31
   //        on a mips64*-* triple.
-  if ((TheTriple.getArch() == Triple::mipsel) ||
-      (TheTriple.getArch() == Triple::mips)) {
+  // TODO: should we also have a Triple::isMIPS32()?
+  if (TheTriple.isMIPS32()) {
----------------
Do you mean that we need to handle isMIPS64() case here? If so, in that case we satisfied by default values of `PrivateGlobalPrefix` and `PrivateLocalPrefix`.


Repository:
  rL LLVM

https://reviews.llvm.org/D48548





More information about the llvm-commits mailing list