[PATCH] D48326: [RFC] "Alternative" matches for TableGen DAG patterns

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 06:06:33 PDT 2018


uweigand added a comment.

In https://reviews.llvm.org/D48326#1136809, @kparzysz wrote:

> I don't think that the new keyword is necessary.  Why not have a new class `Patterns`that takes a list of input dag patterns (otherwise identical to the current `Pattern`), and matches when any of these inputs matches?  Then you can have a `PatFrags` as an analogy to `PatFrag`.


I've now implemented this approach for comparison here:
https://reviews.llvm.org/D48545

Let me know which one is preferable ...


Repository:
  rL LLVM

https://reviews.llvm.org/D48326





More information about the llvm-commits mailing list