[PATCH] D47169: [CMake] Use a different source depending on C++ support

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 01:38:33 PDT 2018


Hahnfeld added a comment.

In https://reviews.llvm.org/D47169#1141852, @phosek wrote:

> There's another solution that's simpler than the two mentioned above which would be to simply avoid using the compiler-rt logic for determining the set of supported targets and instead rely on CMake which is already what `runtimes/` build does except for the host (it's the `COMPILER_RT_DEFAULT_TARGET_ONLY` option). I know which targets I want to build runtimes for, I don't want CMake to go on and try guessing which targets my compiler may or may not support. This needs https://reviews.llvm.org/D45604 but that change is ready to land so I might try and go with that approach.


I think that should work: Overriding the detection if `runtimes/` is known to produce the required dependencies. I don't see how this relies on https://reviews.llvm.org/D45604, but I might be missing something here.


Repository:
  rL LLVM

https://reviews.llvm.org/D47169





More information about the llvm-commits mailing list