[PATCH] D48383: [Dominators] Add the DomTreeUpdater class

Chijun Sima via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 23 08:06:24 PDT 2018


NutshellySima marked 2 inline comments as done.
NutshellySima added inline comments.


================
Comment at: lib/IR/DomTreeUpdater.cpp:319
+      return;
+  if (Ups == UpdateStrategy::Eager) {
+    if (DT)
----------------
kuhar wrote:
> kuhar wrote:
> > I'd put an empty line here too
> I think you missed this.
> Same applies to the ifs below
No. Phabricator does not track the correct line between current and the last patch.


https://reviews.llvm.org/D48383





More information about the llvm-commits mailing list