[PATCH] D48494: [doc] Show the git config for Windows to do line-endings correctly

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 22 12:51:52 PDT 2018


I’m personally against recommending input for the aforementioned reasons
On Fri, Jun 22, 2018 at 12:49 PM Reid Kleckner via Phabricator <
reviews at reviews.llvm.org> wrote:

> rnk added a comment.
>
> I personally use `false`, but maybe `input` would be a good way to go
> going forward. Honestly, let's go ahead and recommend `input`. Even if our
> .gitattributes files don't say the right thing today, we can fix that over
> time, and then things will be more likely to work out of the box.
>
> "autocrlf true" is obviously broken (I think it causes LLVM tests to
> fail), so we need to recommend something. It might as well be the way
> forward that doesn't rely on new contributors all configuring their editors
> correctly.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D48494
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180622/55624398/attachment.html>


More information about the llvm-commits mailing list