[PATCH] D48494: [doc] Show the git config for Windows to do line-endings correctly

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 22 11:18:56 PDT 2018


https://stackoverflow.com/questions/10418975/how-to-change-line-ending-settings

Shows the 3 different settings. I believe #1 is default. You are proposing
#2, which is better but still incorrect in the presence of input files that
are purposely crlf (in case we need to test that our tools can read them).


On Fri, Jun 22, 2018 at 11:14 AM Zachary Turner via Phabricator <
reviews at reviews.llvm.org> wrote:

> zturner added a comment.
>
> I’m not sure what the default is (i think it’s true), but it’s definitely
> not false.
>
> What problems do you see with the default? I’ve been using false for years
> and never had a problem, and many other open source projects require it
> because having the files on your disk not match the files in the repo
> creates its own set of issues
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D48494
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180622/c98e68e6/attachment.html>


More information about the llvm-commits mailing list