[PATCH] D48405: [ELF] Assign RF_EXEC rank even if --no-rosegment or SECTIONS command is used

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 22 10:31:46 PDT 2018


MaskRay added a comment.

You regard these changes:

`llvm-readobj --elf-output-style=GNU` -> `llvm-readelf`
`llvm-mc ... -o %t.o` -> `llvm-mc ... -o %t.o`

as "refactoring". Sorry about all these and I did not know they made you think so. I thought the reviewer would be annoying to see these changes being reviewed twice as I took them as lifting a finger when I happened to change places nearby. (it was really really painful for me to go through the 30+ failing tests and I didn't want to double my work) If you had mercy upon me and let me save my efforts on https://reviews.llvm.org/D48406 I would very appreciate it (also a section layout change and would affect another 30+ failing tests. But the section layout has not been finalized. I do want to remove some hackery DYNSTR DYNSYM nad make them more general).


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48405





More information about the llvm-commits mailing list