[PATCH] D48451: [sanitizers_common] when spawning a subprocess for symbolizers, use posix_spawn instead of fork()

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 22 10:26:29 PDT 2018


kubamracek requested changes to this revision.
kubamracek added a comment.

I've talked to our runtime and kernel folks and we should not be using vfork on Darwin. Even when the behavior you tested seems to work today, it might break tomorrow. Please opt out Darwin from vfork.

Also, it seems best to use posix_spawn wherever it's available. If Android doesn't have it, we should only fallback to fork/vfork on Android.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48451





More information about the llvm-commits mailing list