[PATCH] D28896: [FileCheck] Add directive for checking for blank lines

Greg Bedwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 22 10:10:04 PDT 2018


gbedwell added a comment.

This change would be really really useful for addressing http://llvm.org/PR37871 so I'd like to have this.

The llvm-mca output typically consists of logical "blocks" of info delimited by empty lines:

  Foo
  Bar
  Baz
  
  Wibble
  Wobble

so our tests model this like:

  CHECK:      Foo
  CHECK-NEXT: Bar
  CHECK-NEXT: Baz
  
  CHECK:      Wibble
  CHECK-NEXT: Wobble

which is fine for making sure that the contents of each of these blocks is correct but will miss the case where there is something unexpected in between those blocks.  Being able to instead say:

  CHECK:      Foo
  CHECK-NEXT: Bar
  CHECK-NEXT: Baz
  
  CHECK-EMPTY:
  
  CHECK-NEXT: Wibble
  CHECK-NEXT: Wobble

would be very useful!


https://reviews.llvm.org/D28896





More information about the llvm-commits mailing list