[PATCH] D48405: [ELF] Assign RF_EXEC rank even if --no-rosegment or SECTIONS command is used

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 22 09:48:37 PDT 2018


MaskRay added inline comments.


================
Comment at: test/ELF/arm-exidx-order.s:1
+// REQUIRES: arm
 // RUN: llvm-mc -filetype=obj -triple=armv7a-none-linux-gnueabi %s -o %t
----------------
MaskRay wrote:
> MaskRay wrote:
> > grimar wrote:
> > > Can you avoid unnecessary changes in the patches, please?
> > > Moving "requires" is OK, but can be done separately. Such changes makes doing review harder.
> > Sorry if it did any *unnecessary* changes. But I don't there any change is refactoring.
> s/there/think/
Fixing these tests are already painful and I am not prepared to split to simple `REQUIRES:` moving change to a separate patch (double work for the case that is not worthy)


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48405





More information about the llvm-commits mailing list