[PATCH] D47905: [ThinLTO] Parse module summary index from assembly

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 22 08:59:04 PDT 2018


tejohnson added a comment.

In https://reviews.llvm.org/D47905#1138406, @tejohnson wrote:

> I've address the comments except for adding a new test, which I will work on and that will probably get added tomorrow. I'm about to upload a new patch which is properly stacked on top of the 2 patches I had sent separately.


Adding a test right now that includes all possible summary types and fields in various combinations. This is essentially a combined index, which made testing all combinations significantly easier (no need to come up with matching IR), and also allowed me to test entries that aren't in the per module summaries (the TypeId entries introduced for CFI during the thin link), and force both forward and backwards references to various summary entry types.

This exposed a few issues that I am also uploading the fixes for (some CFI types and a few optional flags weren't being parsed properly, and backwards aliasee references weren't working correctly).

PTAL.


Repository:
  rL LLVM

https://reviews.llvm.org/D47905





More information about the llvm-commits mailing list