[PATCH] D48332: [AArch64] Add custom lowering for v4i8 trunc store

Adhemerval Zanella via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 22 05:25:44 PDT 2018


zatrazz updated this revision to Diff 152458.
zatrazz added a comment.

Updated patch based on previous comments. Indeed, changing AArch64TTIImpl::getMemoryOpCost for both load and store was wrong, since <4 x i8> loads are still scalarized. I have changed to just adjust cost for stores.

I also think widen <2 x i8> and <4 x i8> to <8 x i8> instead of promoting to <4 x i16> is a more comprehensible approach and I will check what kind of adjustment would require to make it profitable in all cases.


https://reviews.llvm.org/D48332

Files:
  lib/Target/AArch64/AArch64ISelLowering.cpp
  lib/Target/AArch64/AArch64ISelLowering.h
  lib/Target/AArch64/AArch64TargetTransformInfo.cpp
  test/Analysis/CostModel/AArch64/store.ll
  test/CodeGen/AArch64/neon-truncStore-extLoad.ll
  test/Transforms/LoopVectorize/AArch64/interleaved-vs-scalar.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48332.152458.patch
Type: text/x-patch
Size: 7558 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180622/158011b0/attachment.bin>


More information about the llvm-commits mailing list