[PATCH] D46907: [llvm-mca] Introduce a sequential container of Stages

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 22 02:56:28 PDT 2018


andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.

LGTM.

Thanks for doing this!



================
Comment at: tools/llvm-mca/llvm-mca.cpp:74
 static cl::opt<std::string>
-    ArchName("march",
-             cl::desc("Target arch to assemble for, "
-                      "see -version for available targets"),
+    ArchName("march", cl::desc("Target arch to assemble for, "
+                               "see -version for available targets"),
----------------
mattd wrote:
> I know the formatting here is not related to the primary idea behind this patch, but I decided to run clang-format on the entire file.  If you prefer, I can ignore the formatting of the options here, and submit that as a NFC later.
No problem. It looks good :-)


https://reviews.llvm.org/D46907





More information about the llvm-commits mailing list