[PATCH] D48240: Try again to implement a FIFO task queue

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 20:27:54 PDT 2018


zturner updated this revision to Diff 152427.
zturner added a comment.

Updated based on more suggestions.  I switched from using `deque` pointer stability to using explicit ids.  I think this makes the code easier to reason about, especially in the followup patch which allows the tasks to return values.  I also split out the `LLVM_ENABLE_THREADS=1` case from the alternative.  They were diverging enough that all the pre-processor branches made it difficult to follow.  I think this is cleaner and more maintainable this way.


https://reviews.llvm.org/D48240

Files:
  llvm/include/llvm/Support/TaskQueue.h
  llvm/unittests/Support/CMakeLists.txt
  llvm/unittests/Support/TaskQueueTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48240.152427.patch
Type: text/x-patch
Size: 10693 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180622/84f037e5/attachment.bin>


More information about the llvm-commits mailing list