[PATCH] D48468: [SelectionDAG] Remove debug locations from ConstantSD(FP)Nodes

[Vedant Kumar via Phabricator via llvm-commits]

vsk created this revision.
vsk added reviewers: echristo, dblaikie, rnk, MatzeB.
Herald added a subscriber: nhaehnle.
Herald added a reviewer: javed.absar.

This removes debug locations from ConstantSDNode and ConstantSDFPNode.

When this kind of node is materialized we no longer create a line table
entry which jumps back to the constant's first point of use. This makes
single-stepping behavior smoother, and it matches the model used by IR,
where Constants have no locations. See this thread for more context:

  http://lists.llvm.org/pipermail/llvm-dev/2018-June/124164.html

I'd like to handle constant BuildVectorSDNodes and to try to eliminate
passing SDLocs to SelectionDAG::getConstant*() in follow-up commits.


https://reviews.llvm.org/D48468

Files:
  include/llvm/CodeGen/SelectionDAGNodes.h
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  test/CodeGen/AArch64/machine-outliner-remarks.ll
  test/DebugInfo/ARM/single-constant-use-preserves-dbgloc.ll
  test/DebugInfo/Generic/constant-sdnodes-have-dbg-location.ll
  test/DebugInfo/Generic/constantfp-sdnodes-have-dbg-location.ll
  test/tools/llvm-objdump/AMDGPU/source-lines.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48468.152419.patch
Type: text/x-patch
Size: 9271 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180622/acad9de2/attachment.bin>