[PATCH] D48271: [llvm-readobj] Fix printing format

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 16:07:01 PDT 2018


dblaikie added a comment.

*looks at this a bit more closely*

Ah, OK, so this is a string dumping mode - why is it dumping non-printable characters at all? (I assumed this was reimplementing/matching behavior of some existing tool (in the same way that llvm-objdump is meant to be like the binutils 'objdump' tool - I just assumed there was a 'readobj' tool out there somewhere, but googling around I don't immediately see anything like that)) more like the way the 'strings' tool would work?

Or is this trying to match some existing/similar behavior elsewhere?


Repository:
  rL LLVM

https://reviews.llvm.org/D48271





More information about the llvm-commits mailing list