[PATCH] D48452: [DWARFv5] Allow ".loc 0" to refer to the root file

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/MC/ELF/dwarf-loc0.s:4
+# REQUIRES: default_triple
+# Darwin is stuck on DWARF v2.
+# XFAIL: darwin
----------------
probinson wrote:
> probinson wrote:
> > aprantl wrote:
> > > That's not true. The default DWARF version for Darwin is 4.
> > Okay... Have things changed recently?  I copied this comment from a test I added in March.  At that time, it took me 3 tries to commit a previous file-0 related patch, and the first attempt did not have this comment in it but the last one did.  I doubt I would have made such a statement without somebody telling me that was so.
> > 
> > I'm happy to take it out but I don't have a way to verify it will work on Darwin without actually committing it.
> Aha.  On Darwin the *line table* is clamped at DWARF v2; see MCDwarf.cpp line ~467.
Ugh. Right. I forgot about that.


Repository:
  rL LLVM

https://reviews.llvm.org/D48452