[PATCH] D48405: [ELF] Assign RF_EXEC rank even if --no-rosegment or SECTIONS command is used

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 13:22:07 PDT 2018


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: ELF/Writer.cpp:767
       Rank |= RF_EXEC_WRITE;
-    else if (!Config->SingleRoRx)
+    else
       Rank |= RF_EXEC;
----------------
echristo wrote:
> Can you rebase this on the other patch and then add some comments about the ranking into the source?
D48406 is based on this one (which I'd like to collect some feedback about section reordering as fixing 60+ tests are painful)

This one D48405 is not dependent on the other.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48405





More information about the llvm-commits mailing list